Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action should immediately fail when it fails to PUT a tag #90

Closed
samruddhikhandale opened this issue Oct 27, 2022 · 4 comments
Closed

Action should immediately fail when it fails to PUT a tag #90

samruddhikhandale opened this issue Oct 27, 2022 · 4 comments
Assignees
@samruddhikhandale

Comments

@samruddhikhandale
Copy link
Member

Issue mentioned here --> devcontainers/spec#61 (comment)

As the corresponding publish action showed a ✅ , the user would not realize that it failed to publish some tag. Need to fail the action as soon as CLI fails to PUT a tag.

// cc @eitsupi
@samruddhikhandale samruddhikhandale mentioned this issue Oct 27, 2022
Closed
@samruddhikhandale samruddhikhandale self-assigned this Nov 4, 2022
@metaskills
Copy link

I ran into this issue when I also found a possible ERR_FR_MAX_BODY_LENGTH_EXCEEDED bug in the CLI here devcontainers/cli#270

@samruddhikhandale
Copy link
Member Author

@joshspicer looks like #105 should fix this issue?

@samruddhikhandale
Copy link
Member Author

oh wait maybe not! The CLI still needs to be changed to return a non-zero exit code

@samruddhikhandale samruddhikhandale mentioned this issue Nov 22, 2022
Merged
@samruddhikhandale
Copy link
Member Author

Closing as fixed with devcontainers/cli#296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samruddhikhandale samruddhikhandale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metaskills @samruddhikhandale