Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an "effective" merged devcontainer.json inclusive of Features from read-configuration command #113

Closed
Chuxel opened this issue Aug 8, 2022 · 1 comment
Labels
feature-request New feature or request

Comments

@Chuxel
Copy link
Member

Chuxel commented Aug 8, 2022

Currently the devcontainers read-configuration command has two modes. One that shows the contents of devcontainer.json and one that also shows the feature configuration for any features referenced (via the --include-features-configuration).

However, what would be most useful would be a way to get a merged configuration inclusive of both out of the CLI. For example, adding a --effective-configuration flag:

$ devcontainer read-configuration --effective-configuration true --workspace-folder .

This would be extremely useful for tool or service implementors that need to any pre-processing steps prior to starting a dev container, or need to inject contents based on the configuration.

As a concrete example, we could use this to modify the tools-vscode-server example under example-usage in this repository to adapt to customizations.vscode.settings and customizations.vscode.extensions through the use of jq and some shell scripts. Right now you'd have to manually parse each feature and do a merge yourself - which could deviate from the standard logic.

@Chuxel
Copy link
Member Author

Chuxel commented Oct 24, 2022

Looks like --include-merged-configuration does exactly this!

@Chuxel Chuxel closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant