Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature layers should be fully independent #291

Closed
kytans opened this issue Nov 20, 2022 · 0 comments · Fixed by #382
Closed

Feature layers should be fully independent #291

kytans opened this issue Nov 20, 2022 · 0 comments · Fixed by #382
Labels
feature-request New feature or request

Comments

@kytans
Copy link

kytans commented Nov 20, 2022

Currently features are all put in a single image that is then added in a layer, which separate layers per feature only for running install.sh.

This means that changes to any feature or adding a feature cause a full rebuild of the devcontainer, and also means that creating a variant of a devcontainer with an extra feature will rebuild all the features.

Instead, each feature should be added in a separate layer, which would mean that only features that are listed later than the changed features need to be reran while earlier features are cached.

This would speed up some use cases considerably and is much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants