Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Introduce path property in devcontainer-feature.json #251

Open
joshspicer opened this issue Jun 12, 2023 · 1 comment
Open

[Proposal] Introduce path property in devcontainer-feature.json #251

joshspicer opened this issue Jun 12, 2023 · 1 comment
Labels
proposal Still under discussion, collecting feedback

Comments

@joshspicer
Copy link
Member

joshspicer commented Jun 12, 2023

The $PATH variable is often modified by Features during installation to make a certain tool/script/etc easily accessible from the command line. A common pattern today is to use containerEnv to modify the path variable, like so:

...
"containerEnv": {
   "PATH": "/home/vscode/dotnet":${PATH}"
}
...

Adding a property path to the devcontainer-feature.json would provide a declarative way for indicate what a Feature author intends to be available at the end. Doing so this way would also limit pollution of the PATH variable by allowing the CLI an easy way to dedupe.

Proposal

Property Type Description
path array An array of strings, each an absolute path that should be injected as a member of the $PATH variable.

ref: #234 (comment)

@joshspicer joshspicer changed the title Introduce PATH property in devcontainer-feature.json [Proposal] Introduce path property in devcontainer-feature.json Jun 19, 2023
@joshspicer joshspicer added the proposal Still under discussion, collecting feedback label Jun 19, 2023
@joshspicer
Copy link
Member Author

Somewhat related: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Still under discussion, collecting feedback
Projects
None yet
Development

No branches or pull requests

1 participant