chapter 05: authentication is not depending in connection anymore, no…

…w depends in an abstraction
devcorpio · Mar 31, 2019 · ed00a64 · ed00a64
1 parent a6f1b3b
commit ed00a64
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/...ersion-principle/refactor/userProvider.js → ...n-principle/refactor/MySQLUserProvider.js b/...ersion-principle/refactor/userProvider.js → ...n-principle/refactor/MySQLUserProvider.js
@@ -1,4 +1,7 @@
-function userProvider(connection) {
+/**
+ * @implements {UserProviderInterface}
+ */
+function mysqlUserProvider(connection) {
     function findUser(username) {
         return connection.fetchAssoc('SELECT * FROM users WHERE username = ?', [
             username,
@@ -10,4 +13,4 @@ function userProvider(connection) {
     };
 }
 
-module.exports = userProvider;
+module.exports = mysqlUserProvider;
diff --git a/chapter-05-the-dependency-inversion-principle/refactor/authentication.js b/chapter-05-the-dependency-inversion-principle/refactor/authentication.js
@@ -1,3 +1,16 @@
+/**
+ * In order to improve the understanding of this code, this file it is supposing to implement the following interface:
+ *
+ * interface UserProviderInterface {
+ *  function findUser(username);
+ * }
+ *
+ * Quack Quack Quack 🦆 typing :D
+ */
+
+/**
+ * @param {UserProviderInterface} userProvider
+ */
 function authentication(userProvider) {
     function checkCredentials(username, password) {
         const user = userProvider.findUser(username);