Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji, unicode, non-ASCII .eth names #22

Open
jhxyz opened this issue Dec 20, 2021 · 6 comments
Open

Emoji, unicode, non-ASCII .eth names #22

jhxyz opened this issue Dec 20, 2021 · 6 comments
Assignees
@brendandebeasi
Labels
blocked Requires 3rd party resolution community-reported Issues sourced from community comments

Comments

@jhxyz
Copy link

jhxyz commented Dec 20, 2021 •
edited
Loading

Emoji, unicode, non-ASCII .eth names result in a 404 page.

ENS is still in discussion on this subject. The outcome of that discussion will inform technical updates to Ethers.js, which is what would power emoji and other special character support on Eth.xyz.

ethers-io/ethers.js#42 (comment)
https://discuss.ens.domains/t/ens-name-normalization/8652/19
@jhxyz jhxyz added the community-reported Issues sourced from community comments label Dec 20, 2021
@jhxyz jhxyz assigned jhxyz and brendandebeasi and unassigned jhxyz Dec 21, 2021
@jhxyz jhxyz changed the title Emoji .eth names i.e. ✨ben✨.eth Emoji & Unicode .eth names i.e. ✨ben✨.eth Dec 21, 2021
@jhxyz
Copy link
Author

jhxyz commented Dec 21, 2021 •
edited
Loading

@brendandebeasi note from https://twitter.com/adraffy/status/1473128565453385732?s=21
image

@brendandebeasi
Copy link
Member

This is related to the underlying ethers.js library we use to resolve ENS names.
ethers-io/ethers.js#42

The maintainer has stated that they may not want to support the full UTF-8 character set due to the possibility of homoglyph attacks. That said, ENS themselves support the full UTF-8 character set, so I would think it makes sense for ethers.js to support this as well.

@jhxyz jhxyz changed the title Emoji & Unicode .eth names i.e. ✨ben✨.eth Emoji, unicode, non-ASCII .eth names Dec 22, 2021
@jhxyz jhxyz added the blocked Requires 3rd party resolution label Dec 24, 2021
@devdotxyz devdotxyz deleted a comment from richiebinance Dec 24, 2021
@devdotxyz devdotxyz deleted a comment from richiebinance Dec 24, 2021
@jhxyz
Copy link
Author

jhxyz commented Dec 24, 2021

Pending Ethers.js update ethers-io/ethers.js#42

@genxyzteam
Copy link

This user has a Chinese prefix in his eth.xyz profile name
sangenghumeng1

https://twitter.com/sangenghumeng1/status/1478066023345451008?s=20

This was referenced Jan 7, 2022
Closed
Open
@genxyzteam
Copy link

https://twitter.com/lookinforgangas/status/1502658571829497856
The Guy
@lookinforgangas
Replying to @xyz @ensdomains
What about emoji domains? 😆😅😂.eth for example?

@jhxyz
Copy link
Author

jhxyz commented Jul 28, 2022

Example names affected, for tracking:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendandebeasi brendandebeasi

Labels
blocked Requires 3rd party resolution community-reported Issues sourced from community comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brendandebeasi @jhxyz @genxyzteam