Merge branch 'main' into feature/tscofing-view-error

Author: developer-bandi

Diff for: CHANGELOG.md

@@ -1,3 +1,20 @@
+## 8.28.0 (2025-03-24)
+
+### 🚀 Features
+
+- **eslint-plugin:** [prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](https://github.com/typescript-eslint/typescript-eslint/pull/10861))
+
+### 🩹 Fixes
+
+- **eslint-plugin:** [no-unsafe-function-type] remove fixable property ([#10986](https://github.com/typescript-eslint/typescript-eslint/pull/10986))
+
+### ❤️ Thank You
+
+- Olivier Zalmanski @OlivierZal
+- Yannick Decat @mho22
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 8.27.0 (2025-03-17)
 
 ### 🚀 Features

Diff for: eslint.config.mjs

@@ -31,6 +31,7 @@ const restrictNamedDeclarations = {
 
 const vitestFiles = [
   'packages/eslint-plugin-internal/tests/**/*.test.{ts,tsx,cts,mts}',
+  'packages/typescript-eslint/tests/**/*.test.{ts,tsx,cts,mts}',
 ];
 
 export default tseslint.config(

Diff for: packages/ast-spec/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 8.28.0 (2025-03-24)
+
+This was a version bump only for ast-spec to align it with other projects, there were no code changes.
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 8.27.0 (2025-03-17)
 
 ### 🩹 Fixes

Diff for: packages/ast-spec/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/ast-spec",
-  "version": "8.27.0",
+  "version": "8.28.0",
   "description": "Complete specification for the TypeScript-ESTree AST",
   "private": true,
   "keywords": [

Diff for: packages/eslint-plugin/CHANGELOG.md

@@ -1,3 +1,20 @@
+## 8.28.0 (2025-03-24)
+
+### 🚀 Features
+
+- **eslint-plugin:** [prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](https://github.com/typescript-eslint/typescript-eslint/pull/10861))
+
+### 🩹 Fixes
+
+- **eslint-plugin:** [no-unsafe-function-type] remove fixable property ([#10986](https://github.com/typescript-eslint/typescript-eslint/pull/10986))
+
+### ❤️ Thank You
+
+- Olivier Zalmanski @OlivierZal
+- Yannick Decat @mho22
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 8.27.0 (2025-03-17)
 
 ### 🚀 Features

Diff for: packages/eslint-plugin/docs/rules/prefer-nullish-coalescing.mdx

@@ -17,6 +17,54 @@ This rule reports when you may consider replacing:
 - An `||` operator with `??`
 - An `||=` operator with `??=`
 - Ternary expressions (`?:`) that are equivalent to `||` or `??` with `??`
+- Assignment expressions (`=`) that can be safely replaced by `??=`
+
+## Examples
+
+<Tabs>
+<TabItem value="❌ Incorrect">
+
+```ts
+declare const a: string | null;
+declare const b: string | null;
+
+const c = a || b;
+
+declare let foo: { a: string } | null;
+declare function makeFoo(): { a: string };
+
+function lazyInitializeFooByTruthiness() {
+  if (!foo) {
+    foo = makeFoo();
+  }
+}
+
+function lazyInitializeFooByNullCheck() {
+  if (foo == null) {
+    foo = makeFoo();
+  }
+}
+```
+
+</TabItem>
+<TabItem value="✅ Correct">
+
+```ts
+declare const a: string | null;
+declare const b: string | null;
+
+const c = a ?? b;
+
+declare let foo: { a: string } | null;
+declare function makeFoo(): { a: string };
+
+function lazyInitializeFoo() {
+  foo ??= makeFoo();
+}
+```
+
+</TabItem>
+</Tabs>
 
 :::caution
 This rule will not work as expected if [`strictNullChecks`](https://www.typescriptlang.org/tsconfig#strictNullChecks) is not enabled.
@@ -255,3 +303,4 @@ If you are not using TypeScript 3.7 (or greater), then you will not be able to u
 
 - [TypeScript 3.7 Release Notes](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html)
 - [Nullish Coalescing Operator Proposal](https://github.com/tc39/proposal-nullish-coalescing/)
+- [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators)

Diff for: packages/eslint-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.27.0",
+  "version": "8.28.0",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -62,10 +62,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.27.0",
-    "@typescript-eslint/type-utils": "8.27.0",
-    "@typescript-eslint/utils": "8.27.0",
-    "@typescript-eslint/visitor-keys": "8.27.0",
+    "@typescript-eslint/scope-manager": "8.28.0",
+    "@typescript-eslint/type-utils": "8.28.0",
+    "@typescript-eslint/utils": "8.28.0",
+    "@typescript-eslint/visitor-keys": "8.28.0",
     "graphemer": "^1.4.0",
     "ignore": "^5.3.1",
     "natural-compare": "^1.4.0",
@@ -76,8 +76,8 @@
     "@types/marked": "^5.0.2",
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.27.0",
-    "@typescript-eslint/rule-tester": "8.27.0",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.28.0",
+    "@typescript-eslint/rule-tester": "8.28.0",
     "ajv": "^6.12.6",
     "cross-env": "^7.0.3",
     "cross-fetch": "*",

Diff for: packages/eslint-plugin/src/rules/consistent-type-exports.ts

@@ -203,13 +203,11 @@ export default createRule<Options, MessageIds>({
         // Cache the first encountered exports for the package. We will need to come
         // back to these later when fixing the problems.
         if (node.exportKind === 'type') {
-          if (sourceExports.typeOnlyNamedExport == null) {
-            // The export is a type export
-            sourceExports.typeOnlyNamedExport = node;
-          }
-        } else if (sourceExports.valueOnlyNamedExport == null) {
+          // The export is a type export
+          sourceExports.typeOnlyNamedExport ??= node;
+        } else {
           // The export is a value export
-          sourceExports.valueOnlyNamedExport = node;
+          sourceExports.valueOnlyNamedExport ??= node;
         }
 
         // Next for the current export, we will separate type/value specifiers.

Diff for: packages/eslint-plugin/src/rules/no-unnecessary-condition.ts

@@ -357,7 +357,7 @@ export default createRule<Options, MessageId>({
       // Since typescript array index signature types don't represent the
       //  possibility of out-of-bounds access, if we're indexing into an array
       //  just skip the check, to avoid false positives
-      if (isArrayIndexExpression(expression)) {
+      if (!isNoUncheckedIndexedAccess && isArrayIndexExpression(expression)) {
         return;
       }
 
@@ -424,12 +424,13 @@ export default createRule<Options, MessageId>({
         //  possibility of out-of-bounds access, if we're indexing into an array
         //  just skip the check, to avoid false positives
         if (
-          !isArrayIndexExpression(node) &&
-          !(
-            node.type === AST_NODE_TYPES.ChainExpression &&
-            node.expression.type !== AST_NODE_TYPES.TSNonNullExpression &&
-            optionChainContainsOptionArrayIndex(node.expression)
-          )
+          isNoUncheckedIndexedAccess ||
+          (!isArrayIndexExpression(node) &&
+            !(
+              node.type === AST_NODE_TYPES.ChainExpression &&
+              node.expression.type !== AST_NODE_TYPES.TSNonNullExpression &&
+              optionChainContainsOptionArrayIndex(node.expression)
+            ))
         ) {
           messageId = 'neverNullish';
         }
@@ -835,7 +836,10 @@ export default createRule<Options, MessageId>({
       // Since typescript array index signature types don't represent the
       //  possibility of out-of-bounds access, if we're indexing into an array
       //  just skip the check, to avoid false positives
-      if (optionChainContainsOptionArrayIndex(node)) {
+      if (
+        !isNoUncheckedIndexedAccess &&
+        optionChainContainsOptionArrayIndex(node)
+      ) {
         return;
       }
 

Diff for: packages/eslint-plugin/src/rules/no-unsafe-function-type.ts

@@ -12,7 +12,6 @@ export default createRule({
       description: 'Disallow using the unsafe built-in Function type',
       recommended: 'recommended',
     },
-    fixable: 'code',
     messages: {
       bannedFunctionType: [
         'The `Function` type accepts any function-like value.',

Diff for: packages/eslint-plugin/src/rules/no-unsafe-return.ts

@@ -80,9 +80,7 @@ export default createRule({
         ts.isArrowFunction(functionTSNode)
           ? getContextualType(checker, functionTSNode)
           : services.getTypeAtLocation(functionNode);
-      if (!functionType) {
-        functionType = services.getTypeAtLocation(functionNode);
-      }
+      functionType ??= services.getTypeAtLocation(functionNode);
       const callSignatures = tsutils.getCallSignaturesOfType(functionType);
       // If there is an explicit type annotation *and* that type matches the actual
       // function return type, we shouldn't complain (it's intentional, even if unsafe)