-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isomorphic-unfetch: Consider making node-fetch a peerDependency #143
Comments
Definitely open to this. |
Peer dependencies are not meant to be optional. This will cause problems with non-node installs. |
How about at least adding a peer dependency on |
Fully support this since
E: I wonder if you shouldn't open a separate issue for visibility. |
@jamiechong you can use |
@developit can |
@matheo want to open a PR? |
@developit , I tried my best to create #156 , but I am stuck to fix the test cases. Can you please take a look? |
I have the case where I'd like to have better control of the version of
node-fetch
used (v3.x beta). If it were a peer dependency I'd be able to do this.The text was updated successfully, but these errors were encountered: