Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isomorphic-unfetch: Consider making node-fetch a peerDependency #143

Open
jamiechong opened this issue Sep 15, 2020 · 8 comments
Open

isomorphic-unfetch: Consider making node-fetch a peerDependency #143

jamiechong opened this issue Sep 15, 2020 · 8 comments

Comments

@jamiechong
Copy link

I have the case where I'd like to have better control of the version of node-fetch used (v3.x beta). If it were a peer dependency I'd be able to do this.

@developit
Copy link
Owner

Definitely open to this.

@carlpaten
Copy link

Peer dependencies are not meant to be optional. This will cause problems with non-node installs.

@mindplay-dk
Copy link

How about at least adding a peer dependency on @types/node-fetch, so building with this package doesn't fail? (see #96)

@carlpaten
Copy link

carlpaten commented Aug 2, 2021

Fully support this since unfetch bundles its own type definitions. Per @mindplay-dk's own comment in that thread,

But either way, it's currently an undeclared dependency - you have to get a build failure and then manually install the package, so I think either that should be fixed, or the dependency should be removed?

E: I wonder if you shouldn't open a separate issue for visibility.

@JustFly1984
Copy link

@jamiechong you can use yarn and resolutions field in package.json to force exact version of dependencies. But be careful, it could break things.

@matheo
Copy link

matheo commented Jan 2, 2022

@developit can node-fetch be updated to v3.1.0 please?

@developit
Copy link
Owner

@matheo want to open a PR?

@RishikeshDarandale
Copy link
Contributor

@developit , I tried my best to create #156 , but I am stuck to fix the test cases. Can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants