Skip to content

fix: Fix off-by-one error in RasterLayer mesh generation #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 1 commit into from
Dec 17, 2025
Merged

fix: Fix off-by-one error in RasterLayer mesh generation #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/deck.gl-raster/src/raster-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,18 @@ export class RasterLayer extends CompositeLayer<RasterLayerProps> {
debug = false,
} = this.props;

const reprojector = new RasterReprojector(reprojectionFns, width, height);
// The mesh is lined up with the upper and left edges of the raster. So if
// we give the raster the same width and height as the number of pixels in
// the image, it'll be omitting the last row and column of pixels.
//
// To account for this, we add 1 to both width and height when generating
// the mesh. This also solves obvious gaps in between neighboring tiles in
// the COGLayer.
const reprojector = new RasterReprojector(
reprojectionFns,
width + 1,
height + 1,
);
reprojector.run(maxError);
const { indices, positions, texCoords } = reprojectorToMesh(reprojector);

Expand Down