Skip to content

Commit ec7dd29

Browse files
authored
fix: AzureStore creation by HTTPS url (#481)
* Bump object-store git tag to f422dc * Add azure URL constructor test
1 parent 50782ed commit ec7dd29

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

Cargo.lock

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ chrono = "0.4.38"
2626
futures = "0.3.31"
2727
http = "1.2"
2828
indexmap = "2"
29-
object_store = "0.12.1"
29+
object_store = "0.12.2"
3030
pyo3 = { version = "0.25", features = ["macros", "indexmap"] }
3131
pyo3-async-runtimes = { version = "0.25", features = ["tokio-runtime"] }
3232
pyo3-file = "0.13"
@@ -37,3 +37,6 @@ url = "2"
3737
[profile.release]
3838
lto = true
3939
codegen-units = 1
40+
41+
[patch.crates-io]
42+
object_store = { git = "https://github.com/apache/arrow-rs-object-store", rev = "f422dce1528ee2a089d8061af639c3f2a9cd43af" }

tests/store/test_azure.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,13 @@ def test_eq():
3232
assert store == store # noqa: PLR0124
3333
assert store == store2
3434
assert store != store3
35+
36+
37+
def test_from_url():
38+
# https://github.com/developmentseed/obstore/issues/477
39+
url = "https://overturemapswestus2.blob.core.windows.net/release"
40+
store = AzureStore.from_url(url, skip_signature=True)
41+
42+
assert store.config.get("container_name") == "release"
43+
assert store.config.get("account_name") == "overturemapswestus2"
44+
assert store.prefix is None

0 commit comments

Comments
 (0)