Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage check to alizer workflows #1164

Closed
Tracked by #1162
thepetk opened this issue Jun 30, 2023 · 2 comments · Fixed by devfile/alizer#13
Closed
Tracked by #1162

Add code coverage check to alizer workflows #1164

thepetk opened this issue Jun 30, 2023 · 2 comments · Fixed by devfile/alizer#13
Assignees
@thepetk
Labels
area/alizer Enhancement or issue related to the alizer repo area/ci area/test-automation Test automation for devfile specification and library

Comments

@thepetk
Copy link
Contributor

thepetk commented Jun 30, 2023 •
edited
Loading

Which area/kind this issue is related to?

/area ci
/area alizer
/area test-automation

Issue Description

Add codecov to the CI and PR checks

target date: 26 July 2023
@openshift-ci openshift-ci bot added area/ci area/alizer Enhancement or issue related to the alizer repo area/test-automation Test automation for devfile specification and library labels Jun 30, 2023
@thepetk thepetk moved this to Backlog in Devfile Project Jun 30, 2023
This was referenced Jun 30, 2023
Closed
Closed
@thepetk thepetk self-assigned this Jul 7, 2023
@thepetk thepetk moved this from Backlog to To Do 📝 in Devfile Project Jul 7, 2023
@thepetk thepetk moved this from To Do 📝 to In Progress 🚧 in Devfile Project Jul 12, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Jul 12, 2023

I've started working on a check inside the ci workflow. I'll calculate the coverage now and put it as a limit. If the new coverage of a PR is below the actual coverage then the tests will fail. So user will have to improve their tests.

@thepetk thepetk mentioned this issue Jul 12, 2023
Merged
2 tasks
@thepetk
Copy link
Contributor Author

thepetk commented Jul 12, 2023

PR created and is now under review.

@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Jul 12, 2023
@thepetk thepetk moved this from In Review 👀 to Done ✅ in Devfile Project Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thepetk thepetk

Labels
area/alizer Enhancement or issue related to the alizer repo area/ci area/test-automation Test automation for devfile specification and library
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test coverage check to CI.yaml thepetk/devfile-alizer
1 participant
@thepetk