Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for kubectl during registry operator testing #1239

Closed
2 tasks
michael-valdron opened this issue Aug 31, 2023 · 0 comments · Fixed by devfile/registry-operator#53
Closed
2 tasks

Support for kubectl during registry operator testing #1239

michael-valdron opened this issue Aug 31, 2023 · 0 comments · Fixed by devfile/registry-operator#53
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/user-story User story for new enhancement

Comments

@michael-valdron
Copy link
Member

/kind user-story

Which area this user story is related to?

/area registry

User Story

As a contributor, I want to use minikube, so that I can test my changes with Kubernetes.

Currently, the registry operator integration test suite only supports the use of oc, https://github.com/devfile/registry-operator/blob/fd4aacc91609bdb18891ce9aeeeb99e439afac03/tests/integration/pkg/client/oc.go. This means though one can still run their integration tests on a Kubernetes cluster it does require that the developer has OpenShift CLI client oc installed. Since the registry operator supports both OpenShift and Kubernetes this should not be a requirement for testing.

Acceptance Criteria

  • Create the same client functions for kubectl
  • Add control logic for all client function invokes to determine which tool to use
    • This could be just if oc is installed and fail if both are not installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/user-story User story for new enhancement
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants