Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry operator incorrect local build source path #1329

Closed
2 tasks done
michael-valdron opened this issue Nov 4, 2023 · 1 comment · Fixed by devfile/registry-operator#58
Closed
2 tasks done
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Nov 4, 2023

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area registry

What versions of software are you using?

Go project

Operating System and version: RHEL 8.8

Go Pkg Version: 1.19

Bug Summary

Describe the bug:

The main.go source paths under manager and run makefile rules are incorrect:

As a result, the local build of the registry operator fails.

To Reproduce:

Run make manager.

Expected behavior

Local build should successfully run and create a executable binary bin/manager.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

test -s /home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/bin/controller-gen && /home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/bin/controller-gen --version | grep -q v0.9.2 || \
GOBIN=/home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/bin GOFLAGS="" go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.9.2
/home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
go build -o /home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/bin/manager ./cmd/main.go
stat /home/mvaldron/source/repos/michael-valdron/devfile-registry-operator/cmd/main.go: directory not found
make: *** [Makefile:122: manager] Error 1

Additional context

Any workaround?

N/A

Suggestion on how to fix the bug

@michael-valdron michael-valdron self-assigned this Nov 4, 2023
@openshift-ci openshift-ci bot added kind/bug Something isn't working area/registry Devfile registry for stacks and infrastructure labels Nov 4, 2023
@michael-valdron michael-valdron moved this to In Progress 🚧 in Devfile Project Nov 4, 2023
@michael-valdron michael-valdron moved this from In Progress 🚧 to In Review 👀 in Devfile Project Nov 4, 2023
@michael-valdron
Copy link
Member Author

PR ready for review: devfile/registry-operator#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant