Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides and publish types for different languages (interested in typescript) #353

Closed
benoitf opened this issue Feb 19, 2021 · 1 comment
Assignees
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 19, 2021

Is your feature request related to a problem? Please describe.
Using devfile v2 from a typescript client, and using https://github.com/kubernetes-client/javascript I have to perform the calls using CustomObjectsApi for custom resources that is returning Object type which is not convenient.

For example listing a Pod I've https://github.com/kubernetes-client/javascript/blob/master/src/gen/model/v1PodList.ts or https://github.com/kubernetes-client/javascript/blob/751488214d58feb40d21038c62a225e09487d600/src/gen/model/v1Pod.ts#L21 allowing to be sure what fields are proposed.

I would want to have a type allowing me to cast to the OpenAPI schema

Describe the solution you'd like
I'm interested in typescript so having a typescript types (d.ts file) published on npmjs.com exposing DevWorkspace object would help to be sure that when the API is changing it's failing at compilation time.

Describe alternatives you've considered
N/A

Additional context
kubernetes-client is using openapi-generator
https://github.com/kubernetes-client/gen/blob/master/openapi/openapi-generator/client-generator.sh

@sleshchenko
Copy link
Member

typescript types are provided in #384
I think it can be closed now. If other languages needs it as well - we need a dedicated issue for each of language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants