Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The core DevWorkspace API should be Che agnostic #5

Closed
l0rd opened this issue Feb 4, 2020 · 2 comments
Closed

The core DevWorkspace API should be Che agnostic #5

l0rd opened this issue Feb 4, 2020 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 4, 2020

If other go projects want to add the devworkspace as a dependency they should be able to import only the core API. For instance chePlugins or cheEditors components should not be part of it.

@l0rd l0rd added the kind/enhancement New feature or request label Feb 4, 2020
@davidfestal
Copy link
Collaborator

When looking into how chePlugin components are defined, and especially, when looking into the schema of the meta.yaml file that defines a chePluign, we can see that it is very general and not that Che specific as it seems.
Renaming chePlugin to plugin, and cheEditor to editor may be a first step.

OTOH, we should probably bear in mind that the content of devfiles is mainly a description of the expected features of the workspace, but it doesn't pull any implementation.

So having some sort of components in the devfile schema that some consumer doesn't need should not be a problem. Not-needed component type could just be ignored, but it will not pull unnecessary implementation code.

@l0rd
Copy link
Contributor Author

l0rd commented Jun 24, 2020

Closing this since the spec is currently che agnostic

@l0rd l0rd closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants