Allow configuring memory and CPU requests / limits

[ibuziuk]

Description

Currently, it is not possible to configure memory and CPU for DWO pod. The only workaround is patching CSV directly, but since the CSV gets replaced as part of an upgrade, the modified value gets reverted to the older default values e.g. for devworkspace-controller-manager

              spec:
                containers:
                  - resources:
                      limits:
                        cpu: '3'
                        memory: 3Gi
                      requests:
                        cpu: 250m
                        memory: 100Mi

Additional context

Need to investigate if we can propagate RAM / CPU configuration from the subscription directly and if it is a good approach in general - https://developers.redhat.com/articles/2023/03/06/5-global-environment-variables-provided-openshift-gitops#

More details https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md

[ibuziuk]

@dkwon17 @AObuchow please, review

[dkwon17]

As discussed, it's possible to set the memory and CPU limits of the DWO pod in the Subscription: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md

Example:

spec:
  channel: fast
  installPlanApproval: Automatic
  name: devworkspace-operator
  source: redhat-operators
  sourceNamespace: openshift-marketplace
  startingCSV: devworkspace-operator.v0.31.1
  config:
    resources:
      limits:
        memory: "4Gi"

However, the resource limits are applied to all containers (2) in the pod, and not just the devworkspace-controller container. Since there are two containers (devworkspace-controller and kube-rbac-proxy), the total memory limit for the configuration above is 8Gi

[dkwon17]

However, the resource limits are applied to all containers (2) in the pod, and not just the devworkspace-controller container. Since there are two containers (devworkspace-controller and kube-rbac-proxy), the total memory limit for the configuration above is 8Gi

If we remove the use of kube-rbac-proxy to use WithAuthenticationAndAuthorization as described in #1352, this won't be a problem anymore.

[rohanKanojia]

In order to use WithAuthenticationAndAuthorization , we need to have controller-runtime >=0.16.0

devworkspace-operator/go.mod

Line 27 in efb5ad6

sigs.k8s.io/controller-runtime v0.14.4

I had created a PR on devfile/api to bump controller-runtime to v0.18.7 devfile/api#1712 . We should be able to work on this after devfile/api is released and we upgrade to new version.