Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate workspace routing into a separate library #298

Closed
metlos opened this issue Mar 4, 2021 · 1 comment · Fixed by #308
Closed

Separate workspace routing into a separate library #298

metlos opened this issue Mar 4, 2021 · 1 comment · Fixed by #308
Assignees
Labels
enhancement New feature or request sprint/current Is assigned to issues which are planned to work on in the current team sprint

Comments

@metlos
Copy link
Contributor

metlos commented Mar 4, 2021

Because the controllers/workspacerouting package is reused in 2 operators now, it would be good if it was separated out of the main devworkspace-operator code into a separate codebase.

This would improve the code isolation and chances of introducing dependencies on code/configuration that is not common to all the operators that use the workspace routing code.

In particular, it would make it possible to not rely on config.ControllerConfig in the workspace routing codepaths, because the configuration mechanism differs between the operators.

@metlos metlos added the enhancement New feature or request label Mar 4, 2021
@amisevsk
Copy link
Collaborator

amisevsk commented Mar 6, 2021

I agree that the code used in the workspaceRouting controller shouldn't depend on any mutable state from elsewhere (i.e. no config settings), but would prefer to keep it in this codebase so that we can share constants, attributes, annotations, etc.

@amisevsk amisevsk self-assigned this Mar 8, 2021
@sleshchenko sleshchenko added the sprint/current Is assigned to issues which are planned to work on in the current team sprint label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants