Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that required webhooks exist on the cluster when a DW has restricted-access annotation #305

Closed
amisevsk opened this issue Mar 6, 2021 · 0 comments
Closed

Check that required webhooks exist on the cluster when a DW has restricted-access annotation #305

amisevsk opened this issue Mar 6, 2021 · 0 comments
Milestone
v0.15.x

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Mar 6, 2021

Description

As a follow-up to #300 (comment), webhooks are enabled by default but the controller only sets up the webhooks deployment at startup. Should we also do an explicit check for webhooks when we encounter the restricted-access annotation?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.x
Development

Successfully merging a pull request may close this issue.

Fail any DevWorkspace when webhooks are not present on cluster amisevsk/devworkspace-operator
1 participant
@amisevsk