Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevWorkspace should have a dedicated phase for terminating #333

Closed
sleshchenko opened this issue Mar 18, 2021 · 0 comments · Fixed by #355
Closed

DevWorkspace should have a dedicated phase for terminating #333

sleshchenko opened this issue Mar 18, 2021 · 0 comments · Fixed by #355
Assignees
@amisevsk
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone
v0.3.0

Comments

@sleshchenko
Copy link
Member

Currently, when dw is terminating(pvc files are cleaning up, or owning objects are removing), it got the latest state (STARTING, RUNNING, FAILED, STOPPED). It would be great if we have a dedicated phase to expose that workspace is checked to be removed and just waits some cleaning up to be done before.
This was referenced Mar 18, 2021
Merged
Closed
@sleshchenko sleshchenko added the sprint/current Is assigned to issues which are planned to work on in the current team sprint label Mar 25, 2021
@sleshchenko sleshchenko added this to the 0.3.0 milestone Mar 25, 2021
@amisevsk amisevsk self-assigned this Mar 25, 2021
@amisevsk amisevsk mentioned this issue Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Add terminating phase for workspaces waiting on finalizers amisevsk/devworkspace-operator
2 participants
@sleshchenko @amisevsk