Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of CHE_API and CHE_API_EXTERNAL #344

Closed
benoitf opened this issue Mar 23, 2021 · 2 comments
Closed

Get rid of CHE_API and CHE_API_EXTERNAL #344

benoitf opened this issue Mar 23, 2021 · 2 comments
Assignees
@tinakurian
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone
v0.4.0

Comments

@benoitf
Copy link
Collaborator

benoitf commented Mar 23, 2021

The devWorkspace is still adding CHE_API, CHE_API_INTERNAL and CHE_API_EXTERNAL env variables

https://github.com/devfile/devworkspace-operator/search?q=DefaultApiEndpoint

as the rest sidecar has been dropped, it should have been deleted as well.
@benoitf
Copy link
Collaborator Author

benoitf commented Mar 23, 2021

maybe the whole https://github.com/devfile/devworkspace-operator/blob/0322bc38a6d798eb02a4bf927c714964c1f88c61/pkg/library/shim/component.go could be removed

@tinakurian tinakurian self-assigned this Mar 24, 2021
This was referenced Mar 24, 2021
Merged
Merged
@sleshchenko sleshchenko added this to the 0.3.0 milestone Mar 24, 2021
@sleshchenko sleshchenko mentioned this issue Mar 25, 2021
Closed
30 tasks
@sleshchenko sleshchenko added the sprint/current Is assigned to issues which are planned to work on in the current team sprint label Mar 25, 2021
@benoitf benoitf mentioned this issue Apr 6, 2021
Merged
9 tasks
@sleshchenko sleshchenko mentioned this issue Apr 14, 2021
Closed
29 tasks
@sleshchenko
Copy link
Member

Fixed by #347

@sleshchenko sleshchenko modified the milestones: 0.3.0, 0.4.0 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinakurian tinakurian

Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
3 participants
@benoitf @sleshchenko @tinakurian