Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevWorkspace operator should better reported found differences on reconcilation #581

Closed
sleshchenko opened this issue Sep 7, 2021 · 0 comments · Fixed by #583
Closed
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@sleshchenko
Copy link
Member

Sometimes it happens that some object (deployment, serviceaccount, service, ...) is endless updating because difference is found. And in most cases it caused by some new or missed default values in desired configuration.

We need to consider adding the same as Che Operator does - report what is actually found differences, always or when running in non-production mode
https://github.com/eclipse-che/che-operator/blob/826475928cd6a3f0be14579663862358d473ea11/pkg/deploy/sync.go#L220

@amisevsk amisevsk self-assigned this Sep 7, 2021
@sleshchenko sleshchenko added this to the v0.10.0 milestone Sep 8, 2021
@sleshchenko sleshchenko added sprint/current Is assigned to issues which are planned to work on in the current team sprint and removed sprint/next labels Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants