Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail DWO startup if it detects another one on the cluster #585

Closed
sleshchenko opened this issue Sep 8, 2021 · 1 comment · Fixed by #588
Closed

Fail DWO startup if it detects another one on the cluster #585

sleshchenko opened this issue Sep 8, 2021 · 1 comment · Fixed by #588
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@sleshchenko
Copy link
Member

It's possible that occasionally two DWO are deployed on the cluster, like on with OLM in openshift-operaotors, another in devworkspace-controller with Che or makefile.

And in such a case all DevWorkspace start being reconciled forever.
It's needed that DWO check if it's only one, if not - fail container start up.
It's possible with webhooks which are cluster scoped, then DWO can check if the referenced deployment exists or webhook is just leftover from the previous installation (since OLM don't clean up webhook and webhook server).

@sleshchenko sleshchenko added sprint/next sprint/current Is assigned to issues which are planned to work on in the current team sprint and removed sprint/next labels Sep 8, 2021
@sleshchenko sleshchenko added this to the v0.10.0 milestone Sep 9, 2021
@sleshchenko
Copy link
Member Author

sleshchenko commented Sep 9, 2021

On a planning I promised to provide more info about my idea, and what can better explain than code? )
So, https://github.com/devfile/devworkspace-operator/compare/failIfTwoDWOAreDeployed?expand=1
but there is still TODO and maybe there is a better place to do that check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants