Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate workspace started state to DevWorkspaceRouting #602

Closed
amisevsk opened this issue Sep 20, 2021 · 0 comments · Fixed by #604 or #617
Closed

Propagate workspace started state to DevWorkspaceRouting #602

amisevsk opened this issue Sep 20, 2021 · 0 comments · Fixed by #604 or #617
Assignees

Comments

@amisevsk
Copy link
Collaborator

Description

As pointed out in #598 (comment), certain config changes are difficult to propagate to DevWorkspaceRoutings (and thus, to the objects that the routing reconciler manages). This is because once services/ingresses/routes are created, there aren't many events on the cluster that trigger new reconciles. Since we do no cleanup when a workspace is stopped, even restarting a workspace may not trigger any reconciles in the routing controller.

One way to work around this would be to propagate the workspaces .spec.started field to the created DevWorkspaceRouting, which would at least trigger reconciles when a workspace is restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant