Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify annotation/labels for the Workspace #698

Closed
benoitf opened this issue Dec 6, 2021 · 0 comments · Fixed by #793
Closed

Allow to specify annotation/labels for the Workspace #698

benoitf opened this issue Dec 6, 2021 · 0 comments · Fixed by #793
Milestone

Comments

@benoitf
Copy link
Collaborator

benoitf commented Dec 6, 2021

Description

With che server workspaces, we could add custom labels and custom annotations to the Deployment/Pod kubernetes object

Additional context

I would like to have the same set of feature by adding extra configuration in the DevWorkspace object

so for example if user provides to Dashboard : ?override.labels.foo=bar then Dashboard can add an extra configuration for foo=bar label into the DevWorkspace and the controller can then apply that label on top of the Deployment/DevWorkspace/Pod objects.

It could be like

devWorkspace.spec.labels and devWorkspace.spec.annotations entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants