Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of imagePullSecrets in deployment is random, causing repeated changes to Deployment #897

Closed
amisevsk opened this issue Jul 28, 2022 · 0 comments · Fixed by #898
Closed
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

When creating a workspace deployment, DWO searches for secrets with the label controller.devfile.io/devworkspace_pullsecret and adds them to the pod's imagePullSecrets. However, this list of secrets is not sorted, and so separate reconciles can modify the workspace deployment, swapping the order of imagePullSecrets. This results in the workspace pod randomly restarting when the workspace is reconciled, and can prevent workspace startup.

How To Reproduce

  1. Create multiple secrets with the controller.devfile.io/devworkspace_pullsecret: true label (controller.devfile.io/watch-secret: true is also required).
  2. Start a DevWorkspace
  3. Check if workspace pod is repeatedly rolled out (setting enableExperimentalFeatures in the DevWorkspaceOperatorConfig will show changes made to the workspace deployment)

Expected behavior

Updates should only be submitted to the cluster if an imagePullSecret needs to be added/removed.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant