Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No configuration for consumer session timeout #153

Open
tparsa opened this issue Jun 20, 2023 · 2 comments
Open

No configuration for consumer session timeout #153

tparsa opened this issue Jun 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tparsa
Copy link

tparsa commented Jun 20, 2023

Hello,

There are cases where the client needs to increase consumer timeout. The default value set in the sarama library is 10 seconds which might not be enough for example sometimes rebalancing a group takes a while resulting in a timeout.

We can easily use the requestTimeout set in the configuration for all of the timeouts.
If this is a valid idea to you I can create a pull request.

@d-rk
Copy link
Collaborator

d-rk commented Jun 21, 2023

Hi @tparsa

exposing additional timeout configuration from sarama is a valid idea. Which config parameter are you talking about.
This one here?
https://github.com/Shopify/sarama/blob/main/config.go#L285

Regards,
Drk

@tparsa
Copy link
Author

tparsa commented Jun 22, 2023

Hello @d-rk

Yes, that's the specific timeout that I needed to change. But generally, we can add all of the configurations that the sarama library can use.

@d-rk d-rk added the enhancement New feature or request label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants