Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Bad code in discordjs-plain-wordmark.svg #1518

Closed
1 task done
cyberalien opened this issue Nov 19, 2022 · 5 comments
Closed
1 task done

[BUG] Bad code in discordjs-plain-wordmark.svg #1518

cyberalien opened this issue Nov 19, 2022 · 5 comments
Assignees
@Snailedlt @lunatic-fox
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet

Comments

@cyberalien
Copy link
Contributor

I have searched through the issues and didn't find my problem.

  • Confirm

Bug description

<g stroke="null" fill="#2A2C3E">

Null is not a valid color

Possible fixes or solutions

<g stroke="none" fill="#2A2C3E">

Additional information

No response
@cyberalien cyberalien added the bug Use this label for pointing out bugs label Nov 19, 2022
@cyberalien
Copy link
Contributor Author

Same issue in related icon discordjs-original-wordmark

@cyberalien
Copy link
Contributor Author

Also qt-original contains stroke="null"

@iuridiniz iuridiniz mentioned this issue Nov 19, 2022
Closed
@Snailedlt
Copy link
Collaborator

If I understand this correctly, you want stroke="null" to be removed, right?

@Snailedlt Snailedlt self-assigned this Nov 20, 2022
@lunatic-fox lunatic-fox self-assigned this Nov 20, 2022
@cyberalien
Copy link
Contributor Author

Yes, removing it is one of solutions. Another solution is to set value to none, which I guess was the intended value but someone made a typo (probably after long coding session dealing with null 😄).

@Snailedlt
Copy link
Collaborator

Ahh, now I see that the solution is different from the bug!
Yeah, I would definitely have done the same 😅

@lunatic-fox lunatic-fox mentioned this issue Nov 20, 2022
Merged
1 task
@Snailedlt Snailedlt added the in-develop The fix/feature is present in `develop` branch but not merged into `master` yet label Dec 10, 2022
@github-actions github-actions bot closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Snailedlt Snailedlt

@lunatic-fox lunatic-fox

Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyberalien @Snailedlt @lunatic-fox