Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows on pull requests failing due to wrong ref #471

Closed
amacado opened this issue Jan 8, 2021 · 4 comments · Fixed by #472
Closed

workflows on pull requests failing due to wrong ref #471

amacado opened this issue Jan 8, 2021 · 4 comments · Fixed by #472
Assignees
Labels
bug Use this label for pointing out bugs

Comments

@amacado
Copy link
Member

amacado commented Jan 8, 2021

Currently the bot:peek command failes (https://github.com/devicons/devicon/pull/217/checks?check_run_id=1671030442). I think this is because of the ref: ${{ github.head_ref }}

https://github.com/devicons/devicon/blob/develop/.github/workflows/peek_icons.yml#L13

ref: ${{ github.head_ref }}

It was merged in #460 and the problem will occur in the other workflow scripts as well I think. @Thomas-Boi what was the reason you changed this? :)

@amacado amacado added the bug Use this label for pointing out bugs label Jan 8, 2021
@Thomas-Boi
Copy link
Member

Oh, that was because the checkout action was having changes from the develop branch AND the PR branch. I thought that it's probably a better idea to just limit the checkout to the PR branch, hence the github.head_ref.

It seems like this would cause the checkout action to checkout the PR branch, which would not belong to us => It has no permission => Script would fail.

I will fix this and push it in a new commit asap.

@Thomas-Boi
Copy link
Member

Created a test PR at #474

@amacado
Copy link
Member Author

amacado commented Jan 8, 2021

sure, just give me a hint when you're done :)

@amacado amacado closed this as completed Jan 9, 2021
@amacado
Copy link
Member Author

amacado commented Jan 9, 2021

Fixed in #472

@amacado amacado linked a pull request Jan 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants