Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTML sub can need video resolution #115

Open
Arias800 opened this issue Jun 12, 2024 · 0 comments
Open

TTML sub can need video resolution #115

Arias800 opened this issue Jun 12, 2024 · 0 comments

Comments

@Arias800
Copy link
Contributor

Arias800 commented Jun 12, 2024

Describe the bug
Maybe it's a specific situation, but sometimes muxing can fail due to a pycaption error : "At least one of video width or height must be given as reference"
It happened because, for some STPP file, pycaption need the video resolution to convert the sub correctly.

To Reproduce
Download an STPP file that is affected by this requirement.

Expected behavior
Conversion should work

To confirm the problem, I manually changed subtitle_text = writer().write(caption_set) in subtitle.py to subtitle_text = writer(video_width=1920, video_height=1080).write(caption_set).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant