Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding ThisAssembly.Git.Tag - separate commit using a plus? #78

Closed
dueringa opened this issue Aug 30, 2018 · 2 comments
Closed

Comments

@dueringa
Copy link
Contributor

ThisAssembly.Git.Tag is currently in the following form, e.g.:

public const string Tag = "v1.2.3-beta4-5-g6789abcd";

However, SemVer states that build metadata should be added via a plus sign, so this would be correct

public const string Tag = "v1.2.3-beta4-5+g6789abcd";

I'm not sure if this field is actually be specified to be a semantic version. So should this be changed or is this intended?

@kzu
Copy link
Member

kzu commented Aug 30, 2018

GitInfo does not force anything on you. If you're happy with that format, you can continue using it. You control precisely everything. That is *your * tag, after all

@kzu kzu closed this as completed Aug 30, 2018
@dueringa
Copy link
Contributor Author

Sorry, my bad, looked at the code again and saw that it results from the output for git describe --tags.

@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants