-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated files should include /// <auto-generated/>
preamble
#273
Comments
@AArnott just curious if you figured out a way around this. I have tried every technique I could find to exclude the file with no luck. |
No. I don't use this package anyway. I can't remember how I came across it initially. Probably some user asked for my help to solve it and I realized it was a problem that needed to be solved here. |
@svause-stryker I had to remove this package from my apps and reimplement. There are analyzers you can turn off, but they have to be done in the csproj instead of the .editorconfig. Besides, the analyzers are correct - string comparison should be done using case sensitive comparer, and I/O should not be done in a source generator. This won't be easily addressed by consumers until kzu reviews and merges #278 and #280, which I don't expect to happen anytime soon. |
Yup I just ripped it out and went a different way. Wasn't ultra important for what I needed it for. |
Looking into this. Sorry it slipped my inbox :( |
Merged and released! https://github.com/devlooped/ThisAssembly/releases/tag/v1.4.2 |
Describe the Bug
When these source generators are used in a project with Stylecop.Analyzers, diagnostics are produced that can block adoption.
Steps to Reproduce
Install
StyleCop.Analyzers
into a project that uses theThisAssembly.Resource
package.Build.
Expected Behavior
No warnings
Actual behavior
Warnings such as this:
Version Info
1.4.1
Additional Info
By adding
/// <auto-generated />
to the top of every emitted file, other analyzers are warned away from reporting frivolous diagnostics.The text was updated successfully, but these errors were encountered: