Skip to content

Checking changes now takes too long because of sha retrieval #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kzu opened this issue Mar 1, 2021 · 0 comments
Closed

Checking changes now takes too long because of sha retrieval #32

kzu opened this issue Mar 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Mar 1, 2021

Previously, running an update was fairly quick, with the optimizations around using HEAD and ETag to conditionally and quickly determine if a full GET was needed.

Since the introduction of the SHA retrieval, however, things are much slower now, since we do a GH CLI call for (almost) all requests.

We should instead optimize and not retrieve the SHA if:

  1. We have a matching ETag from request/response
  2. We already have a SHA persisted

Back this issue
Back this issue

@kzu kzu added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 1, 2021
@kzu kzu closed this as completed in 77f1938 Mar 1, 2021
@devlooped devlooped locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant