Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable minimizing #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathiasbynens
Copy link
Contributor

We can re-enable it once the upstream bugs are fixed: #31

@mathiasbynens
Copy link
Contributor Author

Whoops, didn’t mean to send this PR — but now that I have, I might as well keep it. @devongovett, shall we temporarily disable this until we can figure out what’s going on? That way the output may not be optimal, but at least it would be correct. WDYT?

We can re-enable it once the bugs are fixed:
devongovett#31
@mathiasbynens mathiasbynens changed the title Disable minimizing in Trie class Temporarily disable minimizing Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regexgen bug in minimize() / output depends on order of Trie#addAll input
1 participant