Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to typescript based action #13

Open
rajbos opened this issue Dec 19, 2022 · 2 comments
Open

Convert to typescript based action #13

rajbos opened this issue Dec 19, 2022 · 2 comments

Comments

@rajbos
Copy link
Collaborator

rajbos commented Dec 19, 2022

See 'load-available-actions'

@sebastienvermeille
Copy link
Contributor

Hi @rajbos do you mean you would like to have this action ported to Typescript rather than PowerShell?

Interesting move, I think it will ease contributions

@rajbos
Copy link
Collaborator Author

rajbos commented Aug 15, 2024

Correct. I have a customer that does not have any PowerShell anywhere, and is running their containers exclusively from an internal Artifactory cache. I've learned that them embracing this action has an extra hurdle, as they need to overwrite the container being used and then pull in that extra dependency into Artifactory (so another bump on the road).

Just making this a Typescript based action makes all of those bumps go away, and thus makes it easier to run. It does add a dependency on the correct Node version on the runner, which I am OK with. as I keep those up to date as much as possible in my actions anyway (and most self-hosted runners have to follow along anyway, as GitHub deprecates the old version anyway every once in a while).

Seems like I already started a conversion in the typescript branch, although it misses your last updates ofc. Not sure how far along I was already though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants