Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking out source as tobuild is not ideal #243

Closed
abitmore opened this issue Jan 24, 2021 · 1 comment · Fixed by #245 · May be fixed by #244
Closed

Checking out source as tobuild is not ideal #243

abitmore opened this issue Jan 24, 2021 · 1 comment · Fixed by #245 · May be fixed by #244

Comments

@abitmore
Copy link
Contributor

abitmore commented Jan 24, 2021

Since #239, gitian builder checks out the target tag, branch or commit as a new tobuild tag for building, which is not ideal, because it modifies data in the local git repository. Specifically, by doing so, the git describe --tags command (probably used in source code or build wrapper scripts) may return tobuild unexpectedly (E.G. this code (it would be patched later to remove the new tag before building)).

@devrandom
Copy link
Owner

See proposed fix linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants