Skip to content

Commit 62d32f4

Browse files
committed
fix($sniffer): IE9 backspace bug in compatibility mode
Change IE9 input event workaround in $sniffer to work in compatibility mode (msie can be less than 9) Closes angular#3110
1 parent f4648ab commit 62d32f4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/ng/sniffer.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,10 @@ function $SnifferProvider() {
6969
// IE8 compatible mode lies
7070
(!documentMode || documentMode > 7),
7171
hasEvent: function(event) {
72-
// IE9 implements 'input' event it's so fubared that we rather pretend that it doesn't have
73-
// it. In particular the event is not fired when backspace or delete key are pressed or
74-
// when cut operation is performed.
75-
if (event == 'input' && msie == 9) return false;
72+
// IE9 (and some other versions in compatiblity mode) implements 'input' event but it's so
73+
// fubared that we rather pretend that it doesn't have it. In particular the event is not fired
74+
// when backspace or delete key are pressed or when cut operation is performed.
75+
if (event == 'input' && msie <= 9) return false;
7676

7777
if (isUndefined(eventSupport[event])) {
7878
var divElm = document.createElement('div');

test/ng/snifferSpec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ describe('$sniffer', function() {
8080
// IE9 implementation is fubared, so it's better to pretend that it doesn't have the support
8181
mockDivElement = {oninput: noop};
8282

83-
expect($sniffer.hasEvent('input')).toBe((msie == 9) ? false : true);
83+
expect($sniffer.hasEvent('input')).toBe((msie <= 9) ? false : true);
8484
});
8585
});
8686

0 commit comments

Comments
 (0)