Allow user to show/hide internal commands in ui #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demetris-manikas
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
demetris-manikas
force-pushed
the
2923-ui-toggle-internal-commands-visibility
branch
from
237ccd3 to
73bbc82
Compare
zerbitx
reviewed
Feb 20, 2025
ui/src/pages/commands/commands.tsx
Outdated
| @@ -81,11 +84,18 @@ class Commands extends React.PureComponent<Props, State> { | |||
| }; | |||
|
|
|||
| render() { | |||
| let commands = this.props.devSpaceConfig.config.commands; | |||
There was a problem hiding this comment.
I checked out your branch, fired it up and got the folllowing errors in the console, preventing the page to load
There was a problem hiding this comment.
Sorry about that.
Trusting typescript is always dodgy.
Give it another try.
added 2 commits
February 20, 2025 19:56
Signed-off-by: Demetris Manikas <dmanikas@admin.grnet.gr>
Signed-off-by: Demetris Manikas <dmanikas@admin.grnet.gr>
demetris-manikas
force-pushed
the
2923-ui-toggle-internal-commands-visibility
branch
from
33869b3 to
aba7119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**What issue type does this pull request address?
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2923
Please provide a short message that should be published in the DevSpace release notes
Allow users to toggle the visibility of internal commands in the ui
What else do we need to know?