Merge pull request #353 from devstress/copilot/suppress-warnings-in-flinkjobmanager

devstress · web-flow · commit 3e04d42ce919 · 2025-10-27T18:38:41.000Z
Suppress SonarCloud RSPEC-4040 warning for job ID normalization
diff --git a/FlinkDotNet/FlinkDotNet.JobGateway/Services/FlinkJobManager.cs b/FlinkDotNet/FlinkDotNet.JobGateway/Services/FlinkJobManager.cs
@@ -224,9 +224,11 @@ private static string NormalizeFlinkJobId(string jobId)
         }
 
         string hexOnly = s_hexOnlyRegex.Replace(jobId, string.Empty);
+#pragma warning disable S4040 // Lowercase normalization is required for Flink job ID compatibility
         return hexOnly.Length != 32
             ? throw new ArgumentException($"Flink JobId must contain exactly 32 hexadecimal characters (received '{jobId}').", nameof(jobId))
             : hexOnly.ToLowerInvariant();
+#pragma warning restore S4040
     }
 
     private async Task WaitForSqlGatewayReadyAsync(HttpClient client)

Original file line number	Diff line number	Diff line change
`@@ -224,9 +224,11 @@ private static string NormalizeFlinkJobId(string jobId)`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`string hexOnly = s_hexOnlyRegex.Replace(jobId, string.Empty);`
	`227`	`+#pragma warning disable S4040 // Lowercase normalization is required for Flink job ID compatibility`
`227`	`228`	`return hexOnly.Length != 32`
`228`	`229`	`? throw new ArgumentException($"Flink JobId must contain exactly 32 hexadecimal characters (received '{jobId}').", nameof(jobId))`
`229`	`230`	`: hexOnly.ToLowerInvariant();`
	`231`	`+#pragma warning restore S4040`
`230`	`232`	`}`
`231`	`233`
`232`	`234`	`private async Task WaitForSqlGatewayReadyAsync(HttpClient client)`