You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This is both a bug and a feature request.
The current way to expand env variables in the Dex config is error-prone, since it happens before the YAML parsing.
Therefore, weird hacks are needed e.g. to support $ characters in the LDAP bindPW.
We're currently using a workaround there by defining an env variable ${DOLLAR} with value $. #1051 #1382
Describe the solution you'd like to see
Add a toplevel config variable expandEnv which defaults to true (for compatibility with existing config files), but can be set to false by Dex admins who don't need variable expansion at all.
@sagikazarmark an env variable is also fine for me. Then I'll implement it like this. 👍 DEX_EXPAND_ENV = 0 -> don't expand
any other value, or unset -> expand
heidemn-faro
changed the title
Add config variable expandEnv so env variable expansion can be disabled
Allow to disable env variable expansion by setting DEX_EXPAND_ENV = 0
Dec 29, 2020
heidemn-faro
changed the title
Allow to disable env variable expansion by setting DEX_EXPAND_ENV = 0
Allow to disable env variable expansion by setting DEX_EXPAND_ENV = false
Dec 30, 2020
Is your feature request related to a problem? Please describe.
This is both a bug and a feature request.
The current way to expand env variables in the Dex config is error-prone, since it happens before the YAML parsing.
Therefore, weird hacks are needed e.g. to support
$
characters in the LDAPbindPW
.We're currently using a workaround there by defining an env variable
${DOLLAR}
with value$
.#1051
#1382
Describe the solution you'd like to see
Add a toplevel config variable
expandEnv
which defaults totrue
(for compatibility with existing config files), but can be set tofalse
by Dex admins who don't need variable expansion at all.Describe alternatives you've considered
#1838
Additional context
I can make this change, but @sagikazarmark or @bonifaido can you tell me if such a PR would be accepted?
Current implementation:
These parts would be adapted in the PR.
The text was updated successfully, but these errors were encountered: