-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP groups can only be queried by full DN #536
Comments
We could allow the format string to have a "last component" field to accomplish this. E.g.
We considered doing this in the initial approach. Would be happy to have the groups returned also just use the last component.
This would also be a reasonable option. Ultimately we also need to figure out how to provide more expressive configuration for the LDAP connector, or this thing is going to have a ton of flags just to keep up with user's use cases. |
That'd work, but seems like it could be confusing since And, to clarify, when you say "last component", do you mean the RDN (e.g.
This is probably important. Worth looking around to see how other softwares handle LDAP integration. One good example I can think of is devpi-ldap which provides very expressive configuration for LDAP. Are you planning work on this soon? This is blocking a project for me so I'm happy to attempt a PR if you think this is weeks away. |
Just trying to keep things backward compatible, but yeah we may just break it in this case.
The RDN
It's a high priority but I haven't started to explore options. A good proposal would be a big step forward. |
Groups now use a full query. But, going to keep this issue open until we've added documentation. |
Our LDAP implementation uses POSIX-style groups (
objectClass=posixGroup
) which store amemberUid
(e.g.wyatt
) instead of amember
(e.g.uid=wyatt,ou=People,dc=example,dc=com
). Since theID
of the remote identity is set to the user's DN and thesearchGroupFilter
parameter only seems to support searching by thefullUserID
, we can't leverage the groups functionality here because we can't search group membership by DN. Additionally, if I hard-code thesearchGroupFilter
for testing purposes, the group entries that come back are the full DN of the group which is mildly cumbersome for consumers to handle. It might be nice for this to be configurable.I'm beginning to think that for our purposes it might be better to maintain a fork of Dex with a custom connector that suits our needs (and peculiarities) better, but I thought I'd throw these feature requests out there anyway if the maintainers think it would be a net positive:
ID
field to be derived from an attribute (say,uid
) instead of the DNmemberUid
(see this random JIRA issue from the internet that has an interesting approach)cn
) instead of DNIf these are reasonable requests, I'd be happy to submit a PR. Thanks!
The text was updated successfully, but these errors were encountered: