Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing CI #24

Closed
brettz9 opened this issue Feb 28, 2021 · 2 comments · Fixed by #40
Closed

Failing CI #24

brettz9 opened this issue Feb 28, 2021 · 2 comments · Fixed by #40
Labels

Comments

@brettz9
Copy link
Collaborator

brettz9 commented Feb 28, 2021

Things should be fine, but CI is failing currently as our coverage has been reduced due to a canvas issue: Automattic/node-canvas#1646 . I could change the thresholds temporarily until that may be resolved, or do nothing, but thought I'd at least file an explanation.

@brettz9
Copy link
Collaborator Author

brettz9 commented Mar 18, 2023

Besides working around the canvas issue, I've now switched our tests to using native webcrypto which allows things to work in Node 18.14+ but not the other supported versions (this module is not available to Node 14 or 16 and the webcrypto tests will fail in Node 18 before 18.14).

We should probably switch to GitHub Actions to notice the failing CI again, but in any case, just reporting that CI should be ok again once our minimum supported version is Node 18.14.0.

@brettz9
Copy link
Collaborator Author

brettz9 commented Jul 14, 2024

As per #36, we now have new CI, and the failing issue nowadays is for an unrelated issue for Node 22.

The failing for Node 22 is apparently due to Automattic/node-canvas#2377 , but we cannot apply the suggested, updated canvas version as it fails with jsdom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant