Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove palette, replace with direct colors buffer #10

Closed
dy opened this issue Feb 14, 2018 · 3 comments
Closed

Remove palette, replace with direct colors buffer #10

dy opened this issue Feb 14, 2018 · 3 comments

Comments

@dy
Copy link
Member

dy commented Feb 14, 2018

Following discussion with @alexcjohnson and #1.
@dy dy mentioned this issue Feb 15, 2018
Closed
@alexcjohnson
Copy link

@dfcreative is this completed by the work you did for plotly/plotly.js#2377 ?

@dy
Copy link
Member Author

dy commented Feb 22, 2018

@alexcjohnson not exactly. I just extended color palette here.
Actually it takes removing the palette completely, since color ids in palette uint32 are now of the size of the color itself, so palette is useless.

@dy dy changed the title Discretize point colors for palette Remove palette, replace with direct colors buffer Feb 22, 2018
@dy
Copy link
Member Author

dy commented Mar 8, 2018

Fixed in #11

@dy dy closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dy @alexcjohnson