-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for inferrability #1
Comments
I'm thinking of adding type inference checks as a separate column (e.g. using JET.jl as suggested) - |
I guess it fails, because But using JET.jl is a good idea, although I haven't used it yet. |
I think the point of I added JET check to the report and it caught a few cases. I didn't look at them closely yet, but it's in my todo list :) |
Would it be sufficient if each type of check in |
As a side note, even current simple tests uncovered a lot of subtleties and inconsistencies. I'm trying to balance between adding more tests and closing the major gaps, so fine-grained checks for inferrability will not arrive immediately. But later or sooner, they will definitely do! |
I'd argue that we also need to check for inferrability of a function.
Since it is an important factor when considering performance, see for example: FluxML/NNlib.jl#370.
The text was updated successfully, but these errors were encountered: