Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic broadcast #102

Closed
dfdx opened this issue Jan 23, 2022 · 1 comment
Closed

Generic broadcast #102

dfdx opened this issue Jan 23, 2022 · 1 comment

Comments

@dfdx
Copy link
Owner

dfdx commented Jan 23, 2022

As seen in HQDL report, functions that don't have rrule(broadcasted, f, args...) currently fail on Yota. I had [an attempt] to implement generic rrule(), but it was somewhat controversial, so the decision was postponed.

At the moment I see 2 ways to handle it:

  1. Implement generic rrule(::YotaRuleConfig, broadcasted, f, args...), i.e. restricted to YotaRuleConfig.
  2. Have special handling for broadcasted in step_back!().
@dfdx
Copy link
Owner Author

dfdx commented Apr 22, 2022

Implemented via improved tracing. Not very robust, but mostly works :)

@dfdx dfdx closed this as completed Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfdx