Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage with Typescript #13

Open
kylerjensen opened this issue Jun 1, 2020 · 3 comments
Open

Usage with Typescript #13

kylerjensen opened this issue Jun 1, 2020 · 3 comments

Comments

@kylerjensen
Copy link

Anything on the roadmap for adding Typescript definitions to this library? If not, I can add something to DefinitelyTyped.
@dferber90
Copy link
Owner

Thanks for reaching out! This package was an experiment a while ago and I'm a bit surprised by the growing usage :) I started using TypeScript since writing it.

A conversion of the repo to TypeScript might be nicer than maintaining separate types on DefinitelyTyped. If you feel like it, you can convert the repo to TypeScript. I'd accept a PR.

I am not planning on doing it myself as I'm not actively using this package anymore. You could become a maintainer if that's something you're interested in.

@kylerjensen kylerjensen mentioned this issue Jun 2, 2020
Closed
@llinardos
Copy link

@dferber90 you're not actively using this package, are you using another mechanism for visual snapshotting?

@dferber90
Copy link
Owner

I'm not doing VRT at the moment, but I'd recommend something like https://percy.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add typescript support
3 participants
@dferber90 @llinardos @kylerjensen