Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-native line breaks in dfetch init and dfetch freeze manifests #327

Open
spoorcc opened this issue Apr 21, 2022 · 0 comments
Open

Non-native line breaks in dfetch init and dfetch freeze manifests #327

spoorcc opened this issue Apr 21, 2022 · 0 comments
Labels
good first issue Good for newcomers UX Not broken, but frustrating/unclear for users

Comments

@spoorcc
Copy link
Contributor

spoorcc commented Apr 21, 2022

As mentioned by @sach-edna

When dfetch dumps a manifest (https://github.com/dfetch-org/dfetch/blob/main/dfetch/manifest/manifest.py#L231) for instance during dfetch init then the line_break argument is not specified. This seems to default to LF on all platforms.
It is possible to provide a explicit line_break according to https://pyyaml.org/wiki/PyYAMLDocumentation#reference.

We could use os.linesep to make the manifest native on each platform.

This would impact dfetch init and dfetch freeze
@spoorcc spoorcc added good first issue Good for newcomers UX Not broken, but frustrating/unclear for users labels Apr 21, 2022
@spoorcc spoorcc changed the title Line breaks in dfetch init manifest Non-native line breaks in dfetch init and dfetch freeze manifests Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers UX Not broken, but frustrating/unclear for users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spoorcc