Fragment can't be imported more than once

[alexlafroscia]

I noticed that a particular fragment can't be imported more than once.

This becomes a bit confusing in cases where a fragment imports a fragment. I think importing the fragment a second time should result in a no-op rather than an error around the fragment being defined more than once.

Is this something you'd be interested in a PR to fix? If so, I would be happy to put one together!

[csantero]

I'm not sure I understand the problem. I've definitely reused fragments in my apps before. Do you have an example query that fails?

[alexlafroscia]

Yeah! So for example, if there is a "tree" of imports like this:

query.graphql
-> fragment-a.graphql
-> fragment-b.graphql
  -> fragment-a.graphql

an error occurs because fragment-a.graphql is defining a fragment more than once, and the names collide.

I'm kind of new to GraphQL but it seems like importing fragment-a the second time could safely be ignored to avoid this error.

Making sure not to import a fragment multiple times becomes challenging with many queries and fragments, where you are importing a given fragment many times from many different queries.

[csantero]

@alexlafroscia Ah I see - yeah I don't think I've ever had that sort of construct in my app. I'll be happy to look at a PR if you can include a failing test case. Thanks

[alexlafroscia]

Sure thing 👍

[csantero]

@alexlafroscia Is this still a problem for you now that #9 has been merged?

[alexlafroscia]

I don't really have a good way to test this anymore -- I'm no longer at the company where we were running into this. @jasonmit or @offirgolan might be able to follow up and check it out!