Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty Challenge: Prove that Badger loses data #601

Closed
danielmai opened this issue Oct 4, 2018 · 12 comments
Closed

Bounty Challenge: Prove that Badger loses data #601

danielmai opened this issue Oct 4, 2018 · 12 comments
Labels
area/data-loss Issues related to data loss or corruption. bounty/dataloss These issues are related to the Data Loss Bounty Program skip/stale Skip stalebot status/accepted We accept to investigate or work on it.

Comments

@danielmai
Copy link
Contributor

(This is a renewal of the challenge initiated in #570)

The Challenge

We are always looking to proactively fix issues in our software. If you can prove that Badger loses data under certain conditions and provide a reproducible set of instructions of the data loss, we'll pay you $1337 as a cash reward for your finding. You find an issue in Badger and get paid, and we get to improve our software. It's a win-win.

Conditions

  • Badger must be run with SyncWrites=true enabled (the default). Badger only promises durability of successful writes.
  • A valid data loss bug would use public APIs of Badger and use them in the correct way. Creating unwanted behavior by using internal functions, or using the public APIs in an incorrect way, can still be useful to make Badger more robust, but won't constitute a valid entry for this challenge.
  • The steps must be reproducible by the Dgraph team. If we can't reproduce them at our end, we won't consider it a valid entry.
  • The setup must be general enough. If it requires a supercomputer or some crazy RAID array to run, we won't be able to reproduce the issue.
  • We try to keep things simple and intend to pay the same amount for valid issues. However, if the bug only causes Badger to not return data, and the data is fully recoverable by an easy fix to the code -- that's technically not a data loss (See Badger unable to return data after value log GC #578). For those bugs, we reserve the right to pay less than the above mentioned bounty amount. The amount for these bugs will be decided based an internal team review.
  • Challenge participants must adhere to our Code of Conduct. To summarize it briefly, don't be destructive or inflammatory.
  • In cases of disagreement, the Dgraph team will make the final decision.

Submit an entry

If you have a reproducible data loss bug, don't reply here. File a separate GitHub issue with a link to this issue and we'll evaluate it.

@danielmai danielmai added status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it bounty/dataloss These issues are related to the Data Loss Bounty Program labels Oct 4, 2018
@networkimprov
Copy link

A data-loss bug was already filed when you posted this issue. I'd like to collect my bounty :-)

#563

@campoy campoy pinned this issue May 28, 2019
@campoy campoy changed the title Prove that Badger loses data Bounty Challenge: Prove that Badger loses data May 28, 2019
@campoy campoy added area/data-loss Issues related to data loss or corruption. and removed status/needs-attention This issue needs more eyes on it, more investigation might be required before accepting/rejecting it labels May 30, 2019
@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale The issue hasn't had activity for a while and it's marked for closing. label Jun 29, 2019
@stale
Copy link

stale bot commented Jul 6, 2019

This issue was marked as stale and no activity has occurred since then, therefore it will now be closed. Please, reopen if the issue is still relevant.

@stale stale bot closed this as completed Jul 6, 2019
@manishrjain manishrjain reopened this Jul 7, 2019
@stale stale bot removed the status/stale The issue hasn't had activity for a while and it's marked for closing. label Jul 7, 2019
@manishrjain manishrjain added status/accepted We accept to investigate or work on it. skip/stale Skip stalebot labels Jul 7, 2019
@simon-xe-wang
Copy link

I think #995 is a DL issue.

@ForCraft2013
Copy link

ForCraft2013 commented Nov 19, 2019

Maybe this can prove the issue?
#1126

@ForCraft2013
Copy link

@danielmai how can I contact with you? In the already closed issue #1126 you said to email you, but there was no response for long time (10 days). Maybe my emails got into spam... 😔

@danielmai
Copy link
Contributor Author

I've replied to your recent email @ForCraft2013. I never saw the older ones, so thanks for reaching out again.

@ghost
Copy link

ghost commented Mar 29, 2020

hi,
#1280 Comply with standards?

code: #1280 (comment)

@swdee
Copy link

swdee commented Apr 14, 2020

Hi,

I believe issue #1289 meets your bounty criteria, as the bug is causing data loss due to conflict transactions overwriting each other. The values of the last transaction are the ones that get written to the DB instead of the first transaction and subsequent ones returning ErrConflict.

@jarifibrahim
Copy link
Contributor

@swdee Thank you for finding the issue but it isn't a data loss issue. The data is actually written to the disk always. It was a bug in the iteration code because of which the check for key existence was failing. We appreciate your effort in improving badger. Cheers 🌠

@manishrjain manishrjain unpinned this issue Jul 12, 2020
@damz
Copy link
Contributor

damz commented Jul 20, 2020

#1422 is a data loss issue (Badger is losing delete markers, which are data), reproducible using the public API in the way it is intended to be used, that cannot be recovered once it happened.

@minhaj-shakeel
Copy link

Github issues have been deprecated.
This issue has been moved to discuss. You can follow the conversation there and also subscribe to updates by changing your notification preferences.

drawing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-loss Issues related to data loss or corruption. bounty/dataloss These issues are related to the Data Loss Bounty Program skip/stale Skip stalebot status/accepted We accept to investigate or work on it.
Development

No branches or pull requests

11 participants