(release/v1.6) Compaction: Expired keys and delete markers are never purged (#1354) #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compaction process accidentally keeps one more version of expired keys and delete markers than it should, because of logic error in *levelsController.compactBuildTables(). When NumVersionsToKeep is 1, it means that expired keys and delete markers are never actually purged from the LSM tables. Co-authored-by: Julian Hegler <julian.hegler@tanium.com> Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit fd89894)
NamanJain8
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
jarifibrahim
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
…deinc#1354) (hypermodeinc#1510) The compaction process accidentally keeps one more version of expired keys and delete markers than it should, because of logic error in *levelsController.compactBuildTables(). When NumVersionsToKeep is 1, it means that expired keys and delete markers are never actually purged from the LSM tables. Co-authored-by: Julian Hegler <julian.hegler@tanium.com> Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit fd89894) Co-authored-by: Damien Tournoud <damien@platform.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compaction process accidentally keeps one more version of
expired keys and delete markers than it should, because of
logic error in *levelsController.compactBuildTables(). When
NumVersionsToKeep is 1, it means that expired keys and delete
markers are never actually purged from the LSM tables.
Co-authored-by: Julian Hegler julian.hegler@tanium.com
Co-authored-by: Ibrahim Jarif ibrahim@dgraph.io
(cherry picked from commit fd89894)
This cherry-pick PR had conflicts.
This change is