Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add local accessible shutdown REST endpoint to zero nodes #2285

Closed
Pixelfahnder opened this issue Mar 29, 2018 · 2 comments
Closed
Assignees
Labels
exp/beginner Something most people could solve. kind/enhancement Something could be better.

Comments

@Pixelfahnder
Copy link

On Windows it is not possible to use Signals like SIGINT to stop processes. Also the golang documentation features this in different documents regarding Signal handling.

A big benefit for starting up the zero instance as a background service would be to add a /admin/shutdown endpoint that is locally accessible like the one for the server nodes.

  • What version of Dgraph are you using?
    1.0.4 - Windows
@manishrjain manishrjain added the kind/enhancement Something could be better. label Mar 30, 2018
@manishrjain manishrjain added this to the No Deadline milestone Mar 30, 2018
@manishrjain manishrjain added the exp/beginner Something most people could solve. label Jan 16, 2019
@srfrog srfrog self-assigned this Jan 21, 2019
@srfrog
Copy link
Contributor

srfrog commented Jan 26, 2019

@Pixelfahnder i created a shutdown endpoint, but then the team realized this could become a security issue. In production environments it's simpler to access the VM or container and kill the process via signals. On the other side, I improved the shutdown process by looking at this issue. So thank you for reporting it.

@Pixelfahnder
Copy link
Author

@srfrog After a long time I finally realized the work on this. Thank you very much. Following along the other discussions in #2928 as far as I understood, all "/shutdown" mechanisms are removed from all components, is this correct? So what about a proper SIGINT handling on Windows then or how would a proper stop be operated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner Something most people could solve. kind/enhancement Something could be better.
Development

No branches or pull requests

3 participants